Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/asset unlock #578

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Feat/asset unlock #578

merged 2 commits into from
Nov 6, 2024

Conversation

pankcuf
Copy link
Collaborator

@pankcuf pankcuf commented Nov 5, 2024

Issue being fixed or feature implemented

Support Asset Unlock Transaction

What was done?

  • Support both, asset lock & unlock transactions
  • DB migration (v21)
  • Simple unit test

How Has This Been Tested?

Added one unit test

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pankcuf pankcuf requested a review from Syn-McJ November 5, 2024 12:52
Syn-McJ
Syn-McJ approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pankcuf pankcuf merged commit 624e00f into develop Nov 6, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Syn-McJ Syn-McJ Syn-McJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pankcuf @Syn-McJ