Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ZenLedger info #644

Merged
merged 6 commits into from
Apr 4, 2024
Merged

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Apr 1, 2024

Issue being fixed or feature implemented

  • ZenLedger feature needs an entry point and an info dialog.
  • To improve the efficiency of building UI components, migration to SwiftUI is initiated.

What was done?

  • DWToolsMenuViewController migrated to Swift.
  • ToolsMenuViewController content is implemented in SwiftUI.
  • ZenLedger menu item added.
  • ZenLedger info sheet added.

How Has This Been Tested?

Breaking Changes

  • SwiftUI migration.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf April 1, 2024 05:45
@Syn-McJ Syn-McJ self-assigned this Apr 1, 2024

import SwiftUI

struct MenuItem: View {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MenuItem component corresponds to the Figma menu.item component.


import SwiftUI

struct TextIntro: View {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This corresponds to the Figma's text.intro component.


import SwiftUI

struct FeatureTopText: View {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This corresponds to the Figma's feature.top.text component

Comment on lines +27 to +43
TextIntro(
icon: .custom("zenledger_large"),
buttonLabel: NSLocalizedString("Export all transactions", comment: "ZenLedger"),
action: {
print("submit button tapped")
}
) {
FeatureTopText(
title: NSLocalizedString("Simplify your crypto taxes", comment: "ZenLedger"),
text: NSLocalizedString("Connect your crypto wallets to the ZenLedger platform. Learn more and get started with your Dash Wallet transactions.", comment: "ZenLedger"),
label: "zenledger.io",
labelIcon: .custom("external.link"),
linkAction: {
openURL(URL(string: "https://app.zenledger.io/new_sign_up/")!)
}
)
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copying and modifying this code would allow the implementation of any screen that's based on the text.intro component.

Copy link
Collaborator

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Syn-McJ Syn-McJ merged commit b270f6a into dashpay:develop Apr 4, 2024
1 check passed
@Syn-McJ Syn-McJ deleted the feat/zenledger-info branch April 4, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants