Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add guix build info #329

Merged
merged 12 commits into from
Jan 10, 2024
Merged

doc: add guix build info #329

merged 12 commits into from
Jan 10, 2024

Conversation

thephez
Copy link
Collaborator

@thephez thephez commented Jan 4, 2024

Replaces gitian build documentation with guix documentation since gitian is no longer used as of Dash Core v20.

Preview build: https://dash-docs--329.org.readthedocs.build/en/329/docs/user/developers/compiling.html

@thephez thephez marked this pull request as draft January 4, 2024 14:37
@thephez thephez marked this pull request as ready for review January 9, 2024 22:02
successfully, you will also see your own signatures with an ``OK`` status also.
# <signer> = The name associated with your PGP key
# Example: env GUIX_SIGS_REPO=~/guix.sigs SIGNER=alice ./contrib/guix/guix-attest
cd ~/dash
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need here cd ~/dash? if so, need to add also below where's "Signed binaries"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's need here because the previous step would leave you in the guix-sigs directory. If you're going through the steps sequentially, you will already be in the dash directory when you get to "Signed binaries" next.

Copy link

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thephez thephez merged commit 6513314 into dashpay:20.0.0 Jan 10, 2024
@thephez thephez deleted the build-with-guix branch January 10, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants