Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update testnet page #344

Merged
merged 4 commits into from
Feb 27, 2024
Merged

docs: update testnet page #344

merged 4 commits into from
Feb 27, 2024

Conversation

thephez
Copy link
Collaborator

@thephez thephez commented Feb 26, 2024 •
edited
Loading

Link maintenance (update/remove)
Remove unnecessary info

Preview build: https://dash-docs--344.org.readthedocs.build/en/344/docs/user/developers/testnet.html

@thephez thephez requested review from UdjinM6 and strophy February 26, 2024 15:29
@thephez
Copy link
Collaborator Author

thephez commented Feb 26, 2024

@UdjinM6 @strophy Do you think it makes sense to keep all the testnet info from previous releases on the page? I was thinking about removing it.

strophy
strophy previously approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@strophy strophy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say those old sections can be removed, maybe place a link to the release notes for older versions

UdjinM6
UdjinM6 previously approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thephez thephez dismissed stale reviews from UdjinM6 and strophy via b76ac9f February 27, 2024 15:05
@thephez thephez merged commit e8dc844 into dashpay:20.0.0 Feb 27, 2024
@thephez thephez deleted the testnet-page-updates branch February 27, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@strophy strophy strophy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thephez @UdjinM6 @strophy