-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bidirectional references #104
Open
iammadab
wants to merge
190
commits into
develop
Choose a base branch
from
feat/delete-references
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test range from proof * add unbounded right * test for range to proof * add left unbounded * add absence tuple checks to test * test range to inclusive * test for range after proof * test for range after proof * test for range after to inclusive * test for range full proof * update verify proof func to account for unbounded ranges * add verification check for right non inclusive ranges * refactor bounds to return options * update verify function to work with range_after_* queries * fix range_after_proof test * fix range_after_to_proof test * fix range_after_to_proof_inclusive test * fix range_full_proof
fominok
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
referenced items should keep track of all elements that reference them
this allows efficient updates to the references when the base item changes (updated or deleted)
When a base item gets deleted all its references should also get deleted.
When a reference gets deleted, the base item should stop pointing to it.