-
Notifications
You must be signed in to change notification settings - Fork 19
Standardize Authorization header format: use 'Bearer' instead of 'bearer' #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @loli0123456789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a minor but important standardization issue by correcting the case of the Authorization header scheme. The change ensures that the system's WebSocket header format adheres to common HTTP request header conventions and relevant RFC standards, improving compatibility and robustness.
Highlights
- Authorization Header Standardization: The Authorization header scheme has been updated from the lowercase "bearer" to the title-case "Bearer" to ensure compliance with RFC standards and common HTTP practices.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly standardizes the Authorization
header to use Bearer
for WebSocket connections, aligning it with RFC standards and the existing HTTP header implementation in buildHttpHeaders
. This is a good improvement for consistency. I've left one comment regarding a small refactoring opportunity to improve maintainability by extracting the duplicated "Bearer "
string into a constant. Additionally, to ensure this behavior is maintained and prevent future regressions, I recommend adding a unit test that verifies the correct format of the Authorization
header for both WebSocket and HTTP requests.
throws NoApiKeyException { | ||
Map<String, String> headers = new HashMap<>(); | ||
headers.put("Authorization", "bearer " + ApiKey.getApiKey(apiKey)); | ||
headers.put("Authorization", "Bearer " + ApiKey.getApiKey(apiKey)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve maintainability and avoid duplicating string literals, consider extracting "Bearer "
into a class-level constant. This string is also used in the buildHttpHeaders
method on line 51. Creating a constant like private static final String AUTH_BEARER_PREFIX = "Bearer ";
at the class level would centralize this value and make future changes easier.
又看了下python版本的sdk,同样的问题。 |
Fix Authorization header case sensitivity: use 'Bearer' instead of 'bearer'
Align WebSocket header format with HTTP request headers and RFC standards