Resolve Docker build failures, update core dependency constraints #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesbluca
requested review from
ayushdg and
galipremsagar
as code owners
|
Just want to wait for 3.8 CI to run to verify that the min constraints I added work as expected |
Codecov Report
@@ Coverage Diff @@
## main #804 +/- ##
==========================================
+ Coverage 74.88% 75.02% +0.13%
==========================================
Files 71 71
Lines 3588 3588
Branches 748 748
==========================================
+ Hits 2687 2692 +5
+ Misses 771 762 -9
- Partials 130 134 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve the Docker build issues we've been seeing since switching to the DataFusion planner; I also propagated the explicit constraints on
prompt_toolkitandpygmentsto the rest of our packaging / CI environments, as I imagine having a min version on those dependencies is a good thing.Also should note that having the Docker CI @ayushdg was working on in #583 would help to catch issues like this moving forward, though IIRC that got blocked so doesn't need to block this PR unless we run into more issues