Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unxfailing passing queries #843

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Unxfailing passing queries #843

wants to merge 1 commit into from

Conversation

randerzander
Copy link
Collaborator

Enabling more queries in test suite

@charlesbluca
Copy link
Collaborator

Were these queries passing locally for you @randerzander? I've set xfail_strict=true so that xpassing tests should be counted as failures, but it is possible that the set of queries passing on CPU and GPU are different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushdg ayushdg Awaiting requested review from ayushdg ayushdg is a code owner

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randerzander @charlesbluca