Enable/disable public ingress at class instantiation for GCP cluster #477
+12
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jakenotjay
commented
Oct 3, 2025
jakenotjay
commented
- Adds the public ingress parameter to the GCP cluster class
- Allows for direct configuration instead of a hidden config item
…e instances via class instantiation rather than via the config
| self.general_zone = "-".join(self.zone.split("-")[:2]) # us-east1-c -> us-east1 | ||
| self.service_account = service_account or self.config.get("service_account") | ||
| self.instance_scopes = instance_scopes or self.config.get("instance_scopes") | ||
| self.public_ingress = public_ingress or self.config.get("public_ingress", True) |
There was a problem hiding this comment.
Again can we put this default value in the config system? It just makes it easier for folks using the YAML to find the available configuration options.
There was a problem hiding this comment.
Hey jacob, I made this edit as it was already in the config, but wasn't accessible to users creating the cluster programatically, see:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.