Fix binops with one partition #1143
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjzamora
reviewed
Oct 17, 2024
| @@ -2674,3 +2674,32 @@ def test_to_backend_simplify(): | |||
| assert str(df2.expr) != str(df[["y"]].expr) | |||
| df3 = df2.simplify() | |||
| assert str(df3.expr) == str(df[["y"]].expr) | |||
|
|
|||
|
|
|||
| def test_add_different_index_one_partition(): | |||
There was a problem hiding this comment.
As far as I can tell, this test passes for me on main - Is that expected?
There was a problem hiding this comment.
There is a good chance that #1150 fixed this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes dask/dask#11395