Migrate Blockwise to use taskspec #1159
Open
+226
−175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjetter
commented
Nov 5, 2024
Comment on lines
+3769
to
+3778
| subgraphs = {} | ||
| for _expr in self.exprs: | ||
| if isinstance(_expr, Fused): | ||
| subgraph, name = _expr._task(index)[1:3] | ||
| graph.update(subgraph) | ||
| graph[(name, index)] = name | ||
| elif self._broadcast_dep(_expr): | ||
| # When _expr is being broadcasted, we only | ||
| # want to define a fused task for index 0 | ||
| graph[(_expr._name, 0)] = _expr._task(0) | ||
| if self._broadcast_dep(_expr): | ||
| subname = (_expr._name, 0) | ||
| else: | ||
| graph[(_expr._name, index)] = _expr._task(index) | ||
| subname = (_expr._name, index) | ||
| subgraphs[subname] = _expr._task(subname, subname[1]) | ||
|
|
||
| for i, dep in enumerate(self.dependencies()): | ||
| graph[self._blockwise_arg(dep, index)] = "_" + str(i) | ||
| subgraphs[self._blockwise_arg(dep, index)] = "_" + str(i) |
There was a problem hiding this comment.
I have to admit that I don't understand what's going on here but I just went ahead and translated the existing code
phofl
approved these changes
Nov 5, 2024
phofl
requested changes
Nov 5, 2024
|
hmm, there are problems when running the dask/dask tests with |
|
Fix is dask/dask#11495 I will not change the CI config to test this. I can retrigger once dask/dask is merged |
|
Final problem is dask/dask#11496 the test asserts on the pickled graph size which is blowing up with this since deduplication is not working well. That function caching layer was introduced a little prematurely so let's rip it out and deal with this later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is migrating the blockwise expressions and connected ones to the new task spec.
I ran into interesting issues while ripping out the recursion in #1158 and wanted to do this step here first.