Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use _concat for repartition #626

Closed
wants to merge 1 commit into from

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Dec 22, 2023

Closes #625

I don't really like _concat. Starting with the name of it and it's relatively magical rv. It does fix the problem.

FWIW I encountered this in #294 during division calculation since the optimization is now different and includes a postcompute, i.e. a repartition

@fjetter
Copy link
Member Author

fjetter commented Dec 22, 2023

I suspect that we'd have to use this in other places as well if this is what we want do to

@phofl
Copy link
Collaborator

phofl commented Dec 22, 2023

See my comment in the issue, this solves this particular case, but having integers in partitions is a general issue that is bad

@fjetter
Copy link
Member Author

fjetter commented Dec 22, 2023

Closing in favor of dask/dask#10739

@fjetter fjetter closed this Dec 22, 2023
@fjetter fjetter deleted the fix_repartition_series branch December 22, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map partitions on a series that yields a scalar per partition cannot be computed
2 participants