Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add necessary metadata for editable labextension installs. #178

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

ian-r-rose
Copy link
Collaborator

Fixes #177 .

This add some (poorly documented) metadata to the __init__.py which is needed for editable installs to work for the frontend code. @jacobtomlinson would you mind taking this for a spin to see if it fixes the issue for you?

I was able to get things working as expected with

pip install -e .   # editable install for the python code
jupyter labextension develop --overwrite    # editable install for the frontend code

@ian-r-rose ian-r-rose added the bug label Mar 16, 2021
@jacobtomlinson
Copy link
Member

That did it! Thanks @ian-r-rose.

I can confirm that if I tweak my local source, run jlpm build and then clear my cache and refresh Jupyter Lab I see the changes.

@jacobtomlinson
Copy link
Member

I notice the command in the README is slightly different from the one you commented above. Will this make a difference?

+ jupyter labextension develop --overwrite
- jupyter labextension develop . --overwrite

@ian-r-rose
Copy link
Collaborator Author

Thanks for checking @jacobtomlinson!

I notice the command in the README is slightly different from the one you commented above. Will this make a difference?

+ jupyter labextension develop --overwrite
- jupyter labextension develop . --overwrite

I believe both should be fine (it defaults to .).

@ian-r-rose ian-r-rose merged commit 87e3f6e into dask:main Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help setting up a development environment
2 participants