Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated job for memray tests #8104

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Dedicated job for memray tests #8104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
433f84d
move memray tests to py3.10
fjetter Aug 14, 2023
41e7cf9
extra test job for memray
fjetter Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ jobs:
environment: mindeps
extra_packages: [numpy]
partition: "not ci1"
- os: ubuntu-latest
environment: mindeps
extra_packages: [memray]
partition: "extra_packages"

# Uncomment to stress-test the test suite for random failures.
# Must also change `export TEST_ID` in first step below.
Expand Down Expand Up @@ -106,7 +110,7 @@ jobs:
if: |
(
steps.skip-caching.outputs.trigger-found != 'true'
&& !(github.event_name == 'pull_request'
&& !(github.event_name == 'pull_request'
&& contains(github.event.pull_request.labels.*.name, 'skip-caching'))
)
id: get-date
Expand All @@ -128,8 +132,8 @@ jobs:
run: mamba env update -n dask-distributed -f ${{ env.CONDA_FILE }}
if: |
(
steps.skip-caching.outputs.trigger-found == 'true'
|| (github.event_name == 'pull_request'
steps.skip-caching.outputs.trigger-found == 'true'
|| (github.event_name == 'pull_request'
&& contains(github.event.pull_request.labels.*.name, 'skip-caching'))
|| steps.cache.outputs.cache-hit != 'true'
)
Expand Down
1 change: 0 additions & 1 deletion continuous_integration/environment-3.9.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ dependencies:
- jinja2 >=2.10.3
- locket >=1.0
- lz4 >=0.23.1 # Only tested here
- memray # Only tested here
- msgpack-python
- netcdf4
- paramiko
Expand Down
1 change: 1 addition & 0 deletions distributed/diagnostics/tests/test_memray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

memray = pytest.importorskip("memray")

pytestmark = pytest.mark.extra_packages
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this marker to have the job run really quickly. We could also mark with memray explicitly. No strong preference.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept it general because we're requiring strict markers and this felt a bit too specific but this doesn't really matter either way


from distributed.diagnostics.memray import memray_scheduler, memray_workers

Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ filterwarnings = [
minversion = "6"
markers = [
"ci1: marks tests as belonging to 1 out of 2 partitions to run on CI ('-m \"not ci1\"' for second partition)",
"extra_packages: marks tests that require a special dependency to run.",
"slow: marks tests as slow (deselected by default", # select with '--runslow')
"avoid_ci: marks tests as flaky or broken on CI on all OSs",
"ipython: marks tests as exercising IPython",
Expand Down