Ensure tokens on futures are unique #8569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesgranger
approved these changes
Mar 11, 2024
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ± 0 27 suites ±0 10h 1m 45s ⏱️ + 8m 0s For more details on these failures, see this check. Results for commit 8d096fd. ± Comparison against base commit 0438768. |
hendrikmakait
approved these changes
Mar 11, 2024
crusaderky
reviewed
Mar 11, 2024
| return Future.make_future, (self.key, self._id) | ||
|
|
||
| def __dask_tokenize__(self): | ||
| return (type(self).__name__, self.key, self._id) |
There was a problem hiding this comment.
Suggested change
| return (type(self).__name__, self.key, self._id) | |
| return (normalize_token(type(self)), self.key, self._id) |
nit - mostly in case a third party subclasses distributed.Future without changing the name
crusaderky
reviewed
Mar 11, 2024
|
|
||
| c.futures[x.key].finish() | ||
|
|
||
| assert tok == tokenize(y) | ||
| assert tok != tokenize(y) |
There was a problem hiding this comment.
Suggested change
| assert tok != tokenize(y) |
nit: redundant with the test above
crusaderky
reviewed
Mar 11, 2024
| @@ -863,11 +863,13 @@ async def test_tokenize_on_futures(c, s, a, b): | |||
| y = c.submit(inc, 1) | |||
| tok = tokenize(x) | |||
There was a problem hiding this comment.
Suggested change
| tok = tokenize(x) |
crusaderky
reviewed
Mar 11, 2024
|
The object dedup was introduced here dask/dask-expr#798 but I will move forward with this now. |
milesgranger
pushed a commit
to milesgranger/distributed
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be the simplest approach to fix #8561
There was a test that asserted on this behavior but I believe this is not an issue.