Drop support for Python 3.9 #8793
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 25 files - 4 25 suites - 4 10h 9m 56s ⏱️ - 1h 52m 29s For more details on these failures, see this check. Results for commit 11bbdad. ± Comparison against base commit 92fc0e2. This pull request skips 2 tests.♻️ This comment has been updated with latest results. |
| - pytest-rerunfailures | ||
| - pytest-timeout | ||
| - python-snappy # Only tested here | ||
| - pytorch # Only tested here |
There was a problem hiding this comment.
There are a couple of "only tested here" dependencies. We should add them to another environment, probably 3.10 is the best one
| - click >=8.0 | ||
| - cloudpickle >=1.5.0 | ||
| - cytoolz >=0.10.1 | ||
| - cloudpickle >=2.0.0 |
There was a problem hiding this comment.
This does not match with the pyproject.toml dependencies. I'm fine with bumping this (according to pypi tags, the first cloudpickle version supporting 3.10 is actually 3.0)
If this goes away, we can also drop some compat code, see
There was a problem hiding this comment.
according to pypi tags, the first cloudpickle version supporting 3.10 is actually 3.0
I went ahead and bumped the dependencies in pyproject.toml to have a minimum of 2.0.0. Looking through the git history, I think the PyPI tags were updated after 3.10 support was actually added. Also fine with bumping to 3.0.0 if folks prefer.
If this goes away, we can also drop some compat code, see
Dropped 👍
| - sortedcontainers >=2.0.5 | ||
| - tblib >=1.6.0 | ||
| - toolz >=0.10.0 | ||
| - tornado >=6.0.4 | ||
| - urllib3 >=1.24.3 | ||
| - tornado >=6.2.0 |
There was a problem hiding this comment.
also doesn't match pyproject.toml
There was a problem hiding this comment.
I guess this is true for all of the above.
Closes #xxxx
pre-commit run --all-files