-
-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Clean tuples dict keys from workers_info in /api/v1/retire_workers. #8996
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this
It should partly solve this issue: #8370 |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files + 1 27 suites +1 11h 46m 9s ⏱️ + 36m 8s For more details on these failures and errors, see this check. Results for commit 200dde6. ± Comparison against base commit fd3722d. |
I would appreciate @fjetter or @hendrikmakait taking a look at this. |
One question would be, are we supposed to retire a worker that still has |
Fix JSON serialization error in retire_workers API endpoint
When retiring workers through the HTTP API endpoint
/api/v1/retire_workers
, the response includes worker metrics that contain tuple keys (e.g.,digests_total_since_heartbeat
). These tuple keys cannot be JSON serialized, causing a 500 error that breaks clients like the Dask Kubernetes Operator.This PR:
clean_dict
function to delete tuple keys during serializationExample: