-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow zoneinfo objects #916
Conversation
raise ValueError("Time-zone information could not be serialised: " | ||
"%s, please use another" % str(dtype.tz)) from e | ||
elif isinstance(dtype, pd.DatetimeTZDtype): | ||
if isinstance(dtype.tz, zoneinfo.ZoneInfo): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if isinstance(dtype.tz, zoneinfo.ZoneInfo): | |
if getattr(dtype.tz, "zone", False): |
?
update cibuildwheel to 2.16.5 ? Aside from the wheels, a name is coming out as type int in writer, which is not allowed by parquet (in test_tz_zoneinfo) |
Sorry about that delay here. I fix the test where the column name was coming out as an int |
There is some dask config option that says "don't use dask-expr" we'll need to set, since they didn't bother to implement fastparquet stuff (that already existed). |
Still hitting dask-expr code somehow:
|
Added an |
Would you also like to fix the
errors from new pandas? |
I would prefer to address that in a follow up to avoid to scope creep in this PR |
closes #915