Merge pull request #16 from dasmeta/DMVP-435-additions

Added new configs to deployment.yaml template.
dasmeta · Feb 14, 2022 · 0075d5a · 0075d5a
2 parents 3d10b67 + 7982c56
commit 0075d5a
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 8 deletions.
diff --git a/charts/base/Chart.yaml b/charts/base/Chart.yaml
@@ -15,10 +15,10 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.1.18
+version: 0.1.19
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
 # It is recommended to use it with quotes.
-appVersion: "0.1.18"
+appVersion: "0.1.19"
diff --git a/charts/base/README.md b/charts/base/README.md
@@ -1,7 +1,7 @@
 ```
 dependencies:
   - name: base
-    version: 0.1.18
+    version: 0.1.19
     repository: https://dasmeta.github.io/helm
 ```
 
@@ -94,9 +94,9 @@ Here are 2 examples about this:
 **Alias is not specified, name, version and appVersion are not overridden by parent chart**
 In this case, labels will be like this:**
 
-- `helm.sh/chart: base-0.1.18`
+- `helm.sh/chart: base-0.1.19`
 - `app.kubernetes.io/name: base`
-- `app.kubernetes.io/version: 0.1.18`
+- `app.kubernetes.io/version: 0.1.19`
 
 Chart.yaml
 ```
@@ -109,7 +109,7 @@ appVersion: "0.1.0"
 
 dependencies:
   - name: base
-    version: 0.1.18
+    version: 0.1.19
     repository: https://dasmeta.github.io/helm
 ```
 
@@ -145,7 +145,7 @@ appVersion: "0.1.0"
 
 dependencies:
   - name: base
-    version: 0.1.18
+    version: 0.1.19
     repository: https://dasmeta.github.io/helm
     alias: my-app-base
 ```
@@ -173,7 +173,7 @@ appVersion: "0.1.0"
 
 dependencies:
   - name: base
-    version: 0.1.18
+    version: 0.1.19
     repository: https://dasmeta.github.io/helm
 ```
 

diff --git a/charts/base/templates/deployment.yaml b/charts/base/templates/deployment.yaml
@@ -5,12 +5,22 @@ metadata:
   labels:
     {{- include "base.labels" . | nindent 4 }}
 spec:
+  {{- if .Values.deployment.minReadySeconds}}
+  minReadySeconds: {{ .Values.deployment.minReadySeconds }}
+  {{- end }}
+  {{- if .Values.deployment.revisionHistoryLimit}}
+  revisionHistoryLimit: {{ .Values.deployment.revisionHistoryLimit }}
+  {{- end }}
   {{- if not .Values.autoscaling.enabled }}
   replicas: {{ .Values.replicaCount }}
   {{- end }}
   selector:
     matchLabels:
       {{- include "base.selectorLabels" . | nindent 6 }}
+  {{- if .Values.deployment.strategy }}
+  strategy:
+    {{- toYaml .Values.strategy | nindent 12 }}
+  {{- end }}
   template:
     metadata:
       annotations: