Merge pull request #29 from dasmeta/fixes

Added ability to create a volume by mounting a ConfigMap .
dasmeta · Aug 30, 2022 · 424cd66 · 424cd66
2 parents 9711f65 + 32bceef
commit 424cd66
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 8 deletions.
diff --git a/charts/base/Chart.yaml b/charts/base/Chart.yaml
@@ -15,10 +15,10 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.1.29
+version: 0.1.30
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
 # It is recommended to use it with quotes.
-appVersion: "0.1.29"
+appVersion: "0.1.30"
diff --git a/charts/base/README.md b/charts/base/README.md
@@ -2,7 +2,7 @@
 ```
 dependencies:
   - name: base
-    version: 0.1.29
+    version: 0.1.30
     repository: https://dasmeta.github.io/helm
 ```
 
@@ -95,9 +95,11 @@ Here are 2 examples about this:
 **Alias is not specified, name, version and appVersion are not overridden by parent chart**
 In this case, labels will be like this:**
 
-- `helm.sh/chart: base-0.1.29`
+- `helm.sh/chart: base-0.1.30
+`
 - `app.kubernetes.io/name: base`
-- `app.kubernetes.io/version: 0.1.29`
+- `app.kubernetes.io/version: 0.1.30
+`
 
 Chart.yaml
 ```
@@ -110,7 +112,7 @@ appVersion: "0.1.0"
 
 dependencies:
   - name: base
-    version: 0.1.29
+    version: 0.1.30
     repository: https://dasmeta.github.io/helm
 ```
 
@@ -146,7 +148,7 @@ appVersion: "0.1.0"
 
 dependencies:
   - name: base
-    version: 0.1.29
+    version: 0.1.30
     repository: https://dasmeta.github.io/helm
     alias: my-app-base
 ```
@@ -174,7 +176,7 @@ appVersion: "0.1.0"
 
 dependencies:
   - name: base
-    version: 0.1.29
+    version: 0.1.30
     repository: https://dasmeta.github.io/helm
 ```
 

diff --git a/charts/base/templates/deployment.yaml b/charts/base/templates/deployment.yaml
@@ -101,6 +101,10 @@ spec:
       volumes:
         {{- range $index, $element := .Values.deployment.volumes }}
         - name: {{ coalesce $element.name (add $index 1) }}
+          {{- if $element.configMap }}
+          configMap:
+            name: {{ $element.configMap.name }}
+          {{- end }}
           {{- if $element.persistentVolumeClaim }}
           persistentVolumeClaim:
             {{- if $element.persistentVolumeClaim.claimName }}