Merge pull request #14 from dasmeta/DMVP-85-external-secrets

External Secrets Update
dasmeta · Jan 18, 2022 · 50b41f8 · 50b41f8
2 parents 39239f0 + e97a3ba
commit 50b41f8
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 13 deletions.
diff --git a/charts/base/Chart.yaml b/charts/base/Chart.yaml
@@ -15,10 +15,10 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.1.16
+version: 0.1.17
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
 # It is recommended to use it with quotes.
-appVersion: "0.1.16"
+appVersion: "0.1.17"
diff --git a/charts/base/README.md b/charts/base/README.md
@@ -1,7 +1,7 @@
 ```
 dependencies:
   - name: base
-    version: 0.1.16
+    version: 0.1.17
     repository: https://dasmeta.github.io/helm
 ```
 
@@ -94,9 +94,9 @@ Here are 2 examples about this:
 **Alias is not specified, name, version and appVersion are not overridden by parent chart**
 In this case, labels will be like this:**
 
-- `helm.sh/chart: base-0.1.16`
+- `helm.sh/chart: base-0.1.17`
 - `app.kubernetes.io/name: base`
-- `app.kubernetes.io/version: 0.1.16`
+- `app.kubernetes.io/version: 0.1.17`
 
 Chart.yaml
 ```
@@ -109,7 +109,7 @@ appVersion: "0.1.0"
 
 dependencies:
   - name: base
-    version: 0.1.16
+    version: 0.1.17
     repository: https://dasmeta.github.io/helm
 ```
 
@@ -145,7 +145,7 @@ appVersion: "0.1.0"
 
 dependencies:
   - name: base
-    version: 0.1.16
+    version: 0.1.17
     repository: https://dasmeta.github.io/helm
     alias: my-app-base
 ```
@@ -173,7 +173,7 @@ appVersion: "0.1.0"
 
 dependencies:
   - name: base
-    version: 0.1.16
+    version: 0.1.17
     repository: https://dasmeta.github.io/helm
 ```
 

diff --git a/charts/base/templates/external-secrets.yaml b/charts/base/templates/external-secrets.yaml
@@ -13,12 +13,10 @@ spec:
     name: {{ $fullName }}
     creationPolicy: Owner
   data:
-  {{- range $index, $secret := .Values.secrets }}
-  {{ $key := $secret }}
-  {{ $property := $secret }}
-  - secretKey: {{ $key }}
+  {{- range $secret := .Values.secrets }}
+  - secretKey: {{ $secret }}
     remoteRef:
       key: {{ $.Values.product }}/{{ $.Values.env }}/{{ $fullName }}
-      property: {{ $property }}
+      property: {{ $secret }}
   {{- end }}
 {{- end }}