Merge pull request #122 from dasmeta/DMVP-5971

fix(DMVP-5971): Update chart for support annotation and terminationgr…
dasmeta · Nov 6, 2024 · 8da817f · 8da817f
2 parents ed8bc6a + 91a0eb3
commit 8da817f
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/charts/base/Chart.yaml b/charts/base/Chart.yaml
@@ -15,10 +15,10 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.2.5
+version: 0.2.6
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
 # It is recommended to use it with quotes.
-appVersion: "0.2.5"
+appVersion: "0.2.6"
diff --git a/charts/base/README.md b/charts/base/README.md
@@ -594,3 +594,11 @@ initContainers:
   args:
     - |
       /test.sh
+
+
+### Deployment use terminationGracePeriodSeconds parameter
+terminationGracePeriodSeconds: 65
+
+### Deployment use chart-hooks
+annotations:
+  "helm.sh/hook": pre-install,pre-upgrade
diff --git a/charts/base/templates/deployment.yaml b/charts/base/templates/deployment.yaml
@@ -9,6 +9,10 @@ metadata:
     {{ $value.name }}: {{ $value.value | quote}}
     {{- end }}
     {{- end }}
+  {{- if .Values.annotations }}
+  annotations:
+    {{- toYaml .Values.annotations | nindent 4 }}
+  {{- end }}
 spec:
   {{- if .Values.minReadySeconds}}
   minReadySeconds: {{ .Values.minReadySeconds }}
@@ -46,6 +50,9 @@ spec:
         {{- end }}
         {{- end }}
     spec:
+      {{- if .Values.terminationGracePeriodSeconds }}
+      terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds | default 30 }}
+      {{- end }}
       {{- with .Values.imagePullSecrets }}
       imagePullSecrets:
         {{- toYaml . | nindent 8 }}