Skip to content

Commit

Permalink
Merge pull request #23 from dasmeta/DMVP-129-service-disable-option
Browse files Browse the repository at this point in the history
DMVP-129 have option to disable service/test-wget-pod
  • Loading branch information
mrdntgrn authored Apr 29, 2022
2 parents 659a105 + bdd5d94 commit 9ba852d
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 8 deletions.
4 changes: 2 additions & 2 deletions charts/base/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.24
version: 0.1.25

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "0.1.24"
appVersion: "0.1.25"
12 changes: 6 additions & 6 deletions charts/base/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
```
dependencies:
- name: base
version: 0.1.24
version: 0.1.25
repository: https://dasmeta.github.io/helm
```

Expand Down Expand Up @@ -94,9 +94,9 @@ Here are 2 examples about this:
**Alias is not specified, name, version and appVersion are not overridden by parent chart**
In this case, labels will be like this:**

- `helm.sh/chart: base-0.1.24`
- `helm.sh/chart: base-0.1.25`
- `app.kubernetes.io/name: base`
- `app.kubernetes.io/version: 0.1.24`
- `app.kubernetes.io/version: 0.1.25`

Chart.yaml
```
Expand All @@ -109,7 +109,7 @@ appVersion: "0.1.0"
dependencies:
- name: base
version: 0.1.24
version: 0.1.25
repository: https://dasmeta.github.io/helm
```

Expand Down Expand Up @@ -145,7 +145,7 @@ appVersion: "0.1.0"
dependencies:
- name: base
version: 0.1.24
version: 0.1.25
repository: https://dasmeta.github.io/helm
alias: my-app-base
```
Expand Down Expand Up @@ -173,7 +173,7 @@ appVersion: "0.1.0"
dependencies:
- name: base
version: 0.1.24
version: 0.1.25
repository: https://dasmeta.github.io/helm
```

Expand Down
2 changes: 2 additions & 0 deletions charts/base/templates/service.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.service.enabled -}}
apiVersion: v1
kind: Service
metadata:
Expand All @@ -13,3 +14,4 @@ spec:
name: {{ .Values.service.name }}
selector:
{{- include "base.selectorLabels" . | nindent 4 }}
{{- end }}
2 changes: 2 additions & 0 deletions charts/base/templates/tests/test-connection.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.service.enabled -}}
apiVersion: v1
kind: Pod
metadata:
Expand All @@ -13,3 +14,4 @@ spec:
command: ['wget']
args: ['{{ include "base.fullname" . }}:{{ .Values.service.port }}']
restartPolicy: OnFailure
{{- end }}
1 change: 1 addition & 0 deletions charts/base/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ securityContext: {}
# runAsUser: 1000

service:
enabled: true
name: http
type: NodePort
port: 80
Expand Down

0 comments on commit 9ba852d

Please sign in to comment.