Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(efs-policy-fix): Add root uid for efs #100

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aghamyan44
Copy link
Contributor

No description provided.

Copy link

what-the-diff bot commented Apr 8, 2024

PR Summary

  • Added a New Attribute to 'storageClass.tf':
    A unique identifier (uid) attribute has been introduced into the 'storageClass.tf' file. This uid is provided a default value of "0". The addition of this uid attribute will enable enhanced tracking and identification, allowing for more efficient management and organization of stored items.

Copy link

github-actions bot commented Apr 8, 2024

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

@@ -8,5 +8,6 @@ resource "kubernetes_storage_class" "efs-storage-class" {
fileSystemId : var.efs_id
directoryPerms : "755"
basePath : "/eks"
uid : "0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we test this change in a setup were we have already used efs? are we sure this change will not break something and it is backward compatible?
do we need to have hardcoded value uid=0 be set always, maybe better to have this configurable from outside with default value?
what is the default behavior when no uid we pass?
will be good to have some description, comment what this config do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants