Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DMVP-4690): Add nginx ingress controller support #102

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

aghamyan44
Copy link
Contributor

No description provided.

Copy link

what-the-diff bot commented Jul 18, 2024

PR Summary

  • Incorporated Nginx Ingress Controller
    A new module called nginx-ingress-controller has been added to enhance the system's traffic management capabilities.

  • Included ALB Ingress Controller
    A new file alb-ingress-controller.tf has been created to integrate the Application Load Balancer, improving load management and distribution.

  • Updated Main Configuration
    The file main.tf has been updated, removing the previous alb-ingress-controller module to minimize redundancies.

  • Created Documentation for Nginx Module
    New README.md files have been added in modules/nginx-ingress-controller/ and its subfolders. These provide clear instructions and explanations regarding the functioning of the Nginx Ingress Controller.

  • Incorporated Test Cases
    Several new files have been added in modules/nginx-ingress-controller/tests/basic/ and tests/eks-nginx-ingress-controller/ directories. These files contain basic and example test cases for ensuring the effectiveness of the newly integrated Nginx Ingress Controller.

  • Generated Configuration Template
    A new file modules/nginx-ingress-controller/values.yaml.tpl has been added. This serves as a template providing default configurations for the Nginx Ingress Controller.

  • Modifications in Variables
    The variables.tf file has been updated to include the nginx_ingress_controller_config variable. This change will allow more precise configuration tweaks enhancing our traffic management flexibility.

With these changes, we are expecting improved traffic management, efficient load distribution, and a more robust system overall.

Copy link

Output

[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
[INFO] Initializing environment for https://github.com/qoomon/git-conventional-commits.
[INFO] Initializing environment for https://github.com/zricethezav/gitleaks.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/zricethezav/gitleaks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

Copy link
Contributor

@aramkarapetian aramkarapetian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aghamyan44 aghamyan44 merged commit 3ef6f85 into main Jul 19, 2024
35 checks passed
@aghamyan44 aghamyan44 deleted the DMVP-4690 branch July 19, 2024 06:56
Copy link

🎉 This PR is included in version 2.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

Output

[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
[INFO] Initializing environment for https://github.com/qoomon/git-conventional-commits.
[INFO] Initializing environment for https://github.com/zricethezav/gitleaks.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/zricethezav/gitleaks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants