Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DMVP-eks-update): Change default values #82

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

aghamyan44
Copy link
Contributor

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Oct 12, 2023

PR Summary

  • Addition of Optional Field to fluent_bit_configs Variable
    The fluent_bit_configs variable in the variables.tf file has been improved. We have introduced a new optional field named kube_namespaces. Until specified, this field will come as an empty set. Furthermore, we have added some more values to the namespace list for drop_namespaces and log_filters fields within the fluent_bit_configs variable.

  • Update to fluent-bit.tf File
    The fluent-bit.tf file has also been updated to now include the kube_namespaces parameter. This parameter will exhibit the default list of namespaces.

@github-actions
Copy link

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

Copy link
Contributor

@aramkarapetian aramkarapetian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aghamyan44 aghamyan44 merged commit fdbfb15 into main Oct 12, 2023
35 checks passed
@aghamyan44 aghamyan44 deleted the DMVP-eks-update branch October 12, 2023 12:26
@github-actions
Copy link

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

@github-actions
Copy link

🎉 This PR is included in version 2.11.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants