Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMVP-0000: Initial PR #83

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

DMVP-0000: Initial PR #83

wants to merge 19 commits into from

Conversation

viktoryathegreat
Copy link
Contributor

Terraform generated PR for best practices changes

@github-actions
Copy link

💰 Infracost estimate: monthly cost will not change

This comment will be updated when the cost estimate changes.

@github-actions
Copy link

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing .github/workflows/terraform-test.yaml
Fixing .github/workflows/checkov.yaml
Fixing .github/workflows/infracost.yaml
Fixing .github/workflows/tflint.yaml

check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

@what-the-diff
Copy link

what-the-diff bot commented Oct 13, 2023

PR Summary

Enhanced Package Ecosystem Control and Workflow Updates

This pull request fundamentally improves the automation and standards-check process in the codebase:

  • Addition of Package Ecosystems to Dependabot
    Dependabot is set up with two new package ecosystems, github-actions and terraform. This enhancement facilitates automated dependency checks and updates on a daily basis for these two ecosystems.

  • New Branch Name Check Workflow
    A new GitHub Actions Workflow file .github/workflows/branch-name-check.yaml has been added. It enforces naming standards and conventions for new branches.

  • Update of 'Checkov' Action Version
    The version of the checkov security tool being used in the .github/workflows/checkov.yaml workflow file has been updated. This ensures improved and up-to-date security analysis of the infrastructure as code (IAC) files.

  • Introduction of Infracost Workflow
    A new workflow file .github/workflows/infracost.yaml has been introduced. This will generate cost estimates for infrastructure changes before they are implemented.

  • Addition of PR Title Checker
    Added a new workflow file .github/workflows/pr-title-checker.yaml that checks and validates the title of incoming Pull Requests for compliance with the project's naming conventions.

  • Update of 'Pre-Commit' Action Version
    The version of the pre-commit action in the .github/workflows/pre-commit.yaml file has been updated. This ensures adherence to the code style guides and best programming practices before any commit is made.

  • Setup-Node Action Version Update in Semantic-Release Workflow
    The version of the setup-node action used in the .github/workflows/semantic-release.yaml file has been updated. This will help in automated package versioning and release.

  • Terraform-Test Action Version Update
    The version of the terraform-test action in the .github/workflows/terraform-test.yaml has been updated. It allows for up-to-date testing of Terraform modules.

  • Tflint and Tfsec Action Version Updates
    The versions of the tflint and tfsec actions in the respective .github/workflows/tflint.yaml and .github/workflows/tfsec.yaml files have been updated. These updates help maintain a higher code quality standard and enhanced security checks for Terraform code.

  • Modification of Commit Message Hook
    The githooks/commit-msg file has been updated. This assists in enforcing certain conditions on the commit messages to improve codebase readability and understanding.

Copy link

github-actions bot commented Nov 3, 2023

Output

[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
[INFO] Initializing environment for https://github.com/qoomon/git-conventional-commits.
[INFO] Initializing environment for https://github.com/zricethezav/gitleaks.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/zricethezav/gitleaks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing .github/workflows/tflint.yaml
Fixing .github/workflows/checkov.yaml
Fixing .github/workflows/terraform-test.yaml

check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

Copy link

github-actions bot commented Nov 3, 2023

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing .github/workflows/tflint.yaml
Fixing .github/workflows/checkov.yaml
Fixing .github/workflows/terraform-test.yaml

check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

1 similar comment
Copy link

github-actions bot commented Nov 3, 2023

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing .github/workflows/tflint.yaml
Fixing .github/workflows/checkov.yaml
Fixing .github/workflows/terraform-test.yaml

check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant