Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DMVP-5969): Add SES module #355

Merged
merged 4 commits into from
Nov 7, 2024
Merged

feat(DMVP-5969): Add SES module #355

merged 4 commits into from
Nov 7, 2024

Conversation

aghamyan44
Copy link
Contributor

No description provided.

Copy link

what-the-diff bot commented Nov 6, 2024

🎉 PR Summary 🎉

This PR includes some important updates to our coding "modules"- think of them as building blocks we use to build our software! 😃

  • Better Security in our File Storage (EFS): 📂🔒

    • We've made sure that by default, any new data stored using the EFS module will be encrypted- meaning safe and secure from prying eyes. 😎
    • We've also given a little tidy-up to the documentation so things are consistent, making life easier for anyone coming along later to understand what we've done. 🧹📚
  • Intro to E-mail Sending Capability (SES): 📧✨

    • A new module has been added which will help us send and manage emails. 💌
    • The update includes setting up some new user accounts and groups, as well as security measures for these setups (kind of like creating email accounts and deciding who has access to what). 🕵️‍♀️
    • A bunch of technical details have also been defined, for things like proving ownership of the email account we're sending from, and where to send a received email. 🏷️🌐
    • We've also ensured that the system will tell us what we're working with- credentials and records are properly output for us to review. 🎯
    • And of course, we've made sure to setup some tests for this new module to ensure everything is running smoothly. 🛠️🧪
    • Our new email module required some new settings to be defined, which we've included in this update. 🎚️

Big strides forward in the security and functionality of our software with these updates! 🕺💃

modules/ses/iam.tf Fixed Show fixed Hide fixed
Copy link

github-actions bot commented Nov 6, 2024

Output

[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[WARNING] repo `https://github.com/pre-commit/pre-commit-hooks` uses deprecated stage names (commit, push) which will be removed in a future version.  Hint: often `pre-commit autoupdate --repo https://github.com/pre-commit/pre-commit-hooks` will fix this.  if it does not -- consider reporting an issue to that repo.
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
[INFO] Initializing environment for https://github.com/qoomon/git-conventional-commits.
[INFO] Initializing environment for https://github.com/zricethezav/gitleaks.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/zricethezav/gitleaks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

Copy link

github-actions bot commented Nov 7, 2024

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

Comment on lines +14 to +17
resource "aws_iam_group" "ses_group" {
name = "${var.prefix}ses_users"
path = "/"
}

Check warning

Code scanning / defsec

IAM groups should have MFA enforcement activated. Warning

Multi-Factor authentication is not enforced for group
@aghamyan44 aghamyan44 changed the title fix(DMVP-5969): Add SES module feat(DMVP-5969): Add SES module Nov 7, 2024
@aghamyan44 aghamyan44 merged commit 630e8e1 into main Nov 7, 2024
122 of 180 checks passed
@aghamyan44 aghamyan44 deleted the DMVP-5969 branch November 7, 2024 07:09
Copy link

github-actions bot commented Nov 7, 2024

🎉 This PR is included in version 2.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Nov 7, 2024

Output

[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[WARNING] repo `https://github.com/pre-commit/pre-commit-hooks` uses deprecated stage names (commit, push) which will be removed in a future version.  Hint: often `pre-commit autoupdate --repo https://github.com/pre-commit/pre-commit-hooks` will fix this.  if it does not -- consider reporting an issue to that repo.
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
[INFO] Initializing environment for https://github.com/qoomon/git-conventional-commits.
[INFO] Initializing environment for https://github.com/zricethezav/gitleaks.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/zricethezav/gitleaks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants