Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make script "toggle" on service start/stop #10

Closed
wants to merge 1 commit into from

Conversation

mainmachine
Copy link

Hey, nice project!

I made a similar but lighter version for my RX580, but I wanted to have defaults reinstated when the service is stopped, so I've modified your script to do this. Thought you might find it useful.

Cheers! :)

@dasunsrule32
Copy link
Owner

Hey, thanks for taking to time to submit this. I'll pull it down and test it over the weekend. I hope to keep adding to the project and provide more depth for sure. I'm glad it works on your rx580. I'll be renaming the scripts from vega-* to amd-* now that I have confirmation from others that it works with their devices.

@mainmachine
Copy link
Author

Sorry, I wasn't clear - I haven't tested this on my RX580, I meant I have a similar script to yours that I use for the same purpose. Looking at your script, the Vega appears to have 4 memory power states, while the RX 580 only has three, so in addition to the vendor specific code blocks you're planning on, you'd have to add GPU or model specific allowances as well.

@dasunsrule32
Copy link
Owner

I'm sorry I haven't had time to look at his yet. I'll work on it as soon as I can. Thanks for your patience. :)

@dasunsrule32
Copy link
Owner

I've gone back and forth on this for a couple of weeks now. I've decided I'm going to rewrite the vega-power-control script. It's a bit of a kluge and needs to be fixed. I opened an issue here. Please comment and let me know your thoughts. Thanks for the submission. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants