error message changes #598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsmekumari
force-pushed
the
e2e_errormsgfix
branch
2 times, most recently
from
ea6b8ad to
341201e
Compare
| @@ -17,8 +17,7 @@ errorMessageInvalidTableName=Spark program 'phase-1' failed with error: Stage 'S | |||
| Errors were encountered during validation. Table 'Table123@' does not exist.. Please check the system logs for more details. | |||
| errorMessageInvalidCredentials=Spark program 'phase-1' failed with error: Unable to create config for batchsink SqlServer \ | |||
| 'connection' is invalid: Failed to assign value | |||
| errorMessageInvalidsourcetable=Spark program 'phase-1' failed with error: Stage 'SQL Server' encountered : io.cdap.cdap.api.exception.ProgramFailureException: \ | |||
| Error occurred while trying to get schema from database.Error message: 'Incorrect syntax near the keyword 'table'.'. | |||
| errorMessageInvalidsourcetable=Spark program 'phase-1' failed with error: Stage 'SQL Server' encountered : io.cdap.cdap.api.exception.ProgramFailureException: | |||
There was a problem hiding this comment.
Error message needs to be changed here rather than making it generic:
Error occurred while trying to get schema from database.Error message: 'No tables used'. Error code: '1096'. SQLState: 'HY000'. Please check the system logs for more details.
similar comment for all other changes like SQL error while getting query schema: in the PR. We need to be more specific with error messages.
There was a problem hiding this comment.
Changes done as suggested.
itsmekumari
force-pushed
the
e2e_errormsgfix
branch
from
341201e to
6ebb931
Compare
itsankit-google
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e2e Fix for dependent PR #597