Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Vulnerability] Run build with unit tests without elevated permissions #47

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

masivesky
Copy link
Contributor

Fix for security vulnerability:
This change prevents any external contributor to create another workflow in the PR with same name as Trigger Build which allow it to run the Build With Unit Tests with elevated permissions.

It uses Github Hosted Runners to build the surefire report with elevated permissions.

@masivesky masivesky self-assigned this Sep 10, 2024
@masivesky masivesky force-pushed the sec-vuln-fix-develop branch 2 times, most recently from 8fad5eb to 54339c9 Compare September 11, 2024 12:43
checkstyle.xml Outdated
<!--
Copyright © 2014-2023 Cask Data, Inc.
Copyright © 2014-2015 Cask Data, Inc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 2014-2024

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed

@masivesky masivesky merged commit 0109bdf into develop Sep 12, 2024
3 checks passed
@masivesky masivesky deleted the sec-vuln-fix-develop branch September 12, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants