Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrangler-groupBy e2e #667

Conversation

AnkitCLI
Copy link
Contributor

@AnkitCLI AnkitCLI commented Sep 12, 2023

e2e test for BQ to BQ using wrangler-groupBy plugin

@AnkitCLI AnkitCLI force-pushed the wrangler-groupby-e2e branch from c88737f to f237d3b Compare September 12, 2023 11:07
@AnkitCLI AnkitCLI changed the title initial commit wrangler-groupBy e2e Sep 12, 2023
@Vipinofficial11 Vipinofficial11 added the build Triggers unit test build label Sep 12, 2023
@AnkitCLI AnkitCLI force-pushed the wrangler-groupby-e2e branch from f237d3b to f43df1a Compare September 13, 2023 07:00
@AnkitCLI AnkitCLI force-pushed the wrangler-groupby-e2e branch from f43df1a to 5e7ddd8 Compare September 14, 2023 05:56
@AnkitCLI AnkitCLI closed this Oct 9, 2023
@AnkitCLI AnkitCLI force-pushed the wrangler-groupby-e2e branch from f7d1e29 to ad7736c Compare October 9, 2023 05:10
@AnkitCLI AnkitCLI reopened this Oct 9, 2023
@AnkitCLI AnkitCLI force-pushed the wrangler-groupby-e2e branch 2 times, most recently from 8fb1bd9 to 4fecb5e Compare November 29, 2023 07:31
@AnkitCLI AnkitCLI force-pushed the wrangler-groupby-e2e branch from 4fecb5e to 4285001 Compare December 31, 2023 10:53
@AnkitCLI AnkitCLI force-pushed the wrangler-groupby-e2e branch 3 times, most recently from 31c4e2c to 2014fdf Compare January 10, 2024 07:34
pom.xml Outdated
@@ -83,7 +83,7 @@
<aws.sdk.version>1.11.133</aws.sdk.version>
<bigquery.connector.hadoop2.version>0.10.2-hadoop2</bigquery.connector.hadoop2.version>
<bouncycastle.version>1.56</bouncycastle.version>
<cdap.version>6.10.0-SNAPSHOT</cdap.version>
<cdap.version>6.11.0-SNAPSHOT</cdap.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar comment like other PRs, change it to 6.10.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to 6.10

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"label": "Wrangler",
"artifact": {
"name": "wrangler-transform",
"version": "4.10.0-SNAPSHOT",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can pass range of plugin here, so that it picks up latest otherwise we will need to always keep changing the version here when plugin version is changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to the latest versions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"label": "BigQueryTable",
"artifact": {
"name": "google-cloud",
"version": "0.23.0-SNAPSHOT",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar comment here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

@itsankit-google itsankit-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use range of version in plugin versions and cdap data pipeline artifact version in the pipeline jsons otherwise we will need to always keep modifying the pipeline.

@itsankit-google itsankit-google added build Triggers unit test build and removed build Triggers unit test build labels Jan 11, 2024
@AnkitCLI AnkitCLI force-pushed the wrangler-groupby-e2e branch 4 times, most recently from 3ec8f59 to 27ac295 Compare January 11, 2024 15:45
@AnkitCLI AnkitCLI force-pushed the wrangler-groupby-e2e branch 2 times, most recently from 484dfe8 to e20018d Compare January 23, 2024 11:49
@AnkitCLI AnkitCLI force-pushed the wrangler-groupby-e2e branch from e20018d to bef211e Compare January 24, 2024 05:45
@itsankit-google itsankit-google merged commit affc6cd into data-integrations:develop Jan 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Triggers unit test build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants