Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2 and generates empty uns if asked for #3

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Fixes #2 and generates empty uns if asked for #3

merged 4 commits into from
Nov 8, 2024

Conversation

LouiseDck
Copy link
Collaborator

@LouiseDck LouiseDck commented Nov 7, 2024 •
edited
Loading

Addresses #2

Do you agree that this adequately solves your issue @rcannood?

@rcannood
Copy link
Member

rcannood commented Nov 7, 2024

Not sure -- can I turn off the nested even if I provide uns_types?

@LouiseDck
Copy link
Collaborator Author

Now you can! I updated the documentation and the tests to reflect that.
You can now provide both uns_types and nested_uns_types.

Thanks for catching that!

rcannood
rcannood approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LouiseDck LouiseDck merged commit 3c44df5 into main Nov 8, 2024
4 checks passed
@LouiseDck LouiseDck deleted the bugfix_emptyuns branch November 8, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcannood rcannood rcannood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LouiseDck @rcannood