CARDS-1904 / CARDS-1937 #1199
Draft
CARDS-1904 / CARDS-1937 #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofi2002sofi
force-pushed
the
CARDS-1937
branch
from
6245465
to
43f02ce
Compare
…nges to the source answer and updates the copied answer
…nges to the source answer and updates the copied answer add checking out and checking in of forms before and after edditing
…nges to the source answer and updates the copied answer remove unnecessary annotation
…nges to the source answer and updates the copied answer avoide deeply nested if statements; simplify getQuestionNode method; add a check for the root node
…ges to the source answer and updates the copied answer create the inner class that saves the value and path of the answer from which it was copied
…nt on change reference answers computed answers
…nt on change reference answers computed answers changed the logic of searching dependent computed answers
sofi2002sofi
force-pushed
the
CARDS-1937
branch
from
43f02ce
to
f89e336
Compare
veronikaslc
reviewed
Feb 17, 2023
| * @return node of question to reference answer | ||
| * @throws RepositoryException if the form data could not be accessed | ||
| */ | ||
| private Node getQuestionNode(final Resource answer, final Session session, final ResourceResolver serviceResolver) |
There was a problem hiding this comment.
Instead of all this method why can't we use questionnaireUtils since it's injected but never actually used in class?
questionnaireUtils.getQuestion(answer.getValueMap().get("question").toString())
veronikaslc
reviewed
Feb 17, 2023
| * @param child node for which the parent form is sought | ||
| * @return string of path the parent form | ||
| */ | ||
| private String getParentFormPath(Resource child) |
There was a problem hiding this comment.
Instead of this method why can't we use formUtils.getForm(child.adaptTo(Node.class)).getPath() ?
veronikaslc
reviewed
Feb 17, 2023
| * @param child node for which the parent form is sought | ||
| * @return node of the parent form | ||
| */ | ||
| private Node getParentFormNode(Node child) throws RepositoryException |
There was a problem hiding this comment.
Same here, formUtils.getForm(child).getPath()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.