Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CARDS-2026: Automatically delete names and emails once they are no longer serving any purpose #1305

Draft
wants to merge 16 commits into
base: dev
Choose a base branch
from

Conversation

veronikaslc
Copy link
Contributor

No description provided.

@marta- marta- added the needs test instructions Not enough information has been provided to perform proper testing label Feb 3, 2023
@marta-
Copy link
Contributor

marta- commented Feb 3, 2023

@veronikaslc this doesn't look like it would depend on CARDS-2020, why is that the base branch?

@marta- marta- changed the base branch from CARDS-2020 to dev February 3, 2023 20:57
@marta- marta- requested a review from sdumitriu February 3, 2023 20:57
@marta- marta- added the needs refactoring The functionality is good, the code needs some improvements label Feb 13, 2023
@marta-
Copy link
Contributor

marta- commented Feb 13, 2023

@veronikaslc The specs to https://phenotips.atlassian.net/browse/CARDS-2026 have been updated to make use of the implementation of the Survey events form.

@veronikaslc veronikaslc removed the needs refactoring The functionality is good, the code needs some improvements label Feb 16, 2023
@sdumitriu
Copy link
Member

I've added a configuration for disabling this, and I also moved the draftLifetime setting in there. Can @veronikaslc add a new admin config screen for it? Also move the draftLifetime config from PatientAccessConfiguration.jsx to the new screen.

…nger serving any purpose

Fixed sql query;
Better sql query readability
…nger serving any purpose

Fixed version and query args
…nger serving any purpose

Only remove the value from the answer, not the whole answer node
…nger serving any purpose

Refactored code wrt changed issue description:
First fetch all Patient information forms for which all Servey events have non null discharged_date
Then for each Patient information form fetch all associated Servey event forms in desc visit order
Look at the latest Servey event form to see if it has at least one non null of responses_received or reminder2_sent answers
veronikaslc and others added 11 commits August 31, 2023 20:03
…nger serving any purpose

Refactored to delete pationt information if there is no Survey events form
Fixed always returning false
…nger serving any purpose

Search only for the patient information forms that do have any private information to remove
…nger serving any purpose

Bugfix: checked in forms cannot be cleared
…nger serving any purpose


Fixed typo in reminder2_sent field

Co-authored-by: Marta Girdea <[email protected]>
…nger serving any purpose

Reduced cyclomatic complexity
…nger serving any purpose

Add configuration for enabling/disabling the task
…onger serving any purpose

Added a new data retension admin config screen
…nger serving any purpose

Change the configuration path to /apps/cards/config/DataRetention
Minor comment fixes
…nger serving any purposeUpdate modules/patient-portal/src/main/frontend/src/patient-portal/DataRetentionConfiguration.jsx


Better wording for labels

Co-authored-by: Sergiu Dumitriu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs test instructions Not enough information has been provided to perform proper testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants