Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CARDS-2483: Questionnaire designer: enable the "select" (dropdown) display mode for multiple choice questions #1695

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

marta-
Copy link
Contributor

@marta- marta- commented Feb 13, 2024

DRAFT because it's being published untested.

To test:

  • setting displayMode: select on text, long, decimal and vocabulary questions from the questionnaire designer
  • how the select questions that accept multiple answer values are behaving in the form edit mode
  • check that answer options with both value and label are displayed and working correctly for select questions
  • check that na options are behaving as expected for multi-valued select questions

@marta- marta- added Test me! Ready for testing easy to review Very few changes, very small time investment to review labels Feb 13, 2024
@sdumitriu
Copy link
Member

No select for double, resource, or vocabulary questions?

@marta-
Copy link
Contributor Author

marta- commented Feb 13, 2024

No select for double, resource, or vocabulary questions?

We don't support answer options for double questions since we discovered issues with "matching" double values to options a while ago, so select doesn't currently apply to this data type.

Resource questions already have the select display mode.

I can add select to vocabulary questions, even though I find it as useless as the simple list display mode in this case, but it doesn't hurt so why not.

@sdumitriu
Copy link
Member

No select for double, resource, or vocabulary questions?

Resource questions already have the select display mode.

Right, I missed it because all other instances have more than just an empty object.

…play mode for multiple choice questions

Added the `select` display mode option to vocabulary questions.
@marta-
Copy link
Contributor Author

marta- commented Feb 13, 2024

No select for double, resource, or vocabulary questions?

We don't support answer options for double questions since we discovered issues with "matching" double values to options a while ago, so select doesn't currently apply to this data type.

See fedf974 .

I can add select to vocabulary questions, even though I find it as useless as the simple list display mode in this case, but it doesn't hurt so why not.

Added in 0c045e9 .

@sashaandjic sashaandjic added testing... Testing in progress bug Something isn't working and removed testing... Testing in progress labels Feb 13, 2024
@sashaandjic
Copy link
Contributor

image

@sashaandjic sashaandjic added testing... Testing in progress bug Something isn't working Test me! Ready for testing and removed bug Something isn't working Test me! Ready for testing testing... Testing in progress labels Mar 5, 2024
@sashaandjic sashaandjic removed the Test me! Ready for testing label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working easy to review Very few changes, very small time investment to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants