CARDS-2509: Reference question should support conditions based on sou… #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rce form metadata
Add optional condition properties to reference questions:
- conditionalProperty: A property on the referenced form to be evaluated
- conditionalOperator: The operator that should be used for the comparison.
Supports all operators supported by Conditional Sections
- conditionalValue: The value that the property should be compared against
- conditionalFallback: The value that should be saved instead of the
referenced value if the condition is not satisfied
- conditionalType: The type of the property that is being compared
Refactored backend conditional section code in order to reuse conditional evaluation code
Update Reference Test forms to add testing support for new conditional references
- Added new section with 4 new questions to the bottom of ReferenceTestCopied.
These questions are conditional on ReferenceTestUser being completed
- Made one question in ReferenceTestUser mandatory to allow the form to be edited
between incomplete and complete
…rce form metadata Add optional error message when a conditional reference is not satisfied - Allows non-text questions to have a text based error display
…rce form metadata - Add invalid source flag to reference questions with no source
sdumitriu
reviewed
Jul 25, 2024
| @@ -50,6 +50,9 @@ public interface FormUtils | |||
| /** The name of the property of a Form node that links to other Subjects the form relates to. */ | |||
| String RELATED_SUBJECTS_PROPERTY = "relatedSubjects"; | |||
|
|
|||
| /** The name of a property on an Answer, Section or Form node that holds the status flags for that node.*/ | |||
| String STATUS_FLAGS = "statusFlags"; | |||
There was a problem hiding this comment.
Suggested change
| String STATUS_FLAGS = "statusFlags"; | |
| String STATUS_FLAGS_PROPERTY = "statusFlags"; |
| /** Answer's property name. **/ | ||
| public static final String VALUE = "value"; | ||
| /** Property on an answer node that stores the a reference to the question. */ | ||
| public static final String QUESTION = "question"; |
There was a problem hiding this comment.
There's also FormUtils.QUESTION_PROPERTY
Comment on lines
218
to
226
| /** | ||
| * Fill out a refernce answer with a value copied from the referenced question. | ||
| * @param versionManager A version manager to be used to checkout forms if needed | ||
| * @param checkoutPaths The list of forms that have been checkout out and need to be checked back in | ||
| * @param sourceAnswerValue The source answer value to copy the answer from | ||
| * @param referenceAnswer The reference answer to copy the value into | ||
| * @param sourceNode The source answer node that the value is being copied from | ||
| * @throws RepositoryException if an unexpected error occurs | ||
| */ |
| */ | ||
|
|
||
| /** | ||
| * Fill out a refernce answer with the value specified as the fallback value. |
There was a problem hiding this comment.
Suggested change
| * Fill out a refernce answer with the value specified as the fallback value. | |
| * Fill out a reference answer with the value specified as the fallback value. |
| @@ -191,31 +187,234 @@ private void checkAndUpdateAnswersValues(final NodeIterator nodeIterator, final | |||
| } | |||
| } | |||
|
|
|||
| private boolean isNotSame(final Property source, final Node reference) throws RepositoryException | |||
| /** | |||
| * Fill out a refernce answer with a value copied from the referenced question. | |||
There was a problem hiding this comment.
Suggested change
| * Fill out a refernce answer with a value copied from the referenced question. | |
| * Fill out a reference answer with a value copied from the referenced question. |
There was a problem hiding this comment.
I want to remove things from cards-utils, not add more things to it, so I'd like to see this moved into its own module, conditions.
| } | ||
| } | ||
| super(values); | ||
| this.reference = reference; |
There was a problem hiding this comment.
Shouldn't this be part of the default Operand?
…rce form metadata - Updated the import script to support conditional properties of reference questions
…rce form metadata - Clean up unused javadoc - Add missing conditional reference columns to questionnaire import - Add missing null checks
sashaandjic
added
bug
|
Steps to reproduce:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rce form metadata
Add optional condition properties to reference questions:
Refactored backend conditional section code in order to reuse conditional evaluation code
Update Reference Test forms to add testing support for new conditional references
To test: