Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HERACLES-33: Historical & Lab Results range/unit revisions #1807

Merged
merged 8 commits into from
Oct 23, 2024
Merged

HERACLES-33: Historical & Lab Results range/unit revisions #1807

merged 8 commits into from
Oct 23, 2024

Conversation

sashaandjic
Copy link
Contributor

@sashaandjic sashaandjic commented Sep 4, 2024 •
edited by marta-
Loading

@sashaandjic

This comment was marked as outdated.

Sign in to view
@marta- marta- dismissed their stale review September 5, 2024 03:54

The comments were addressed

@sashaandjic

This comment was marked as outdated.

Sign in to view
@sashaandjic

This comment was marked as outdated.

Sign in to view
@marta-
Copy link
Contributor

marta- commented Sep 13, 2024

Rebased on the latest dev, squashed commits for cleaner history.

sdumitriu

This comment was marked as resolved.

Sign in to view

@Hajany

This comment was marked as resolved.

Sign in to view
@sashaandjic

This comment was marked as outdated.

Sign in to view
@sashaandjic sashaandjic added the Test me! Ready for testing label Sep 17, 2024
@sdumitriu

This comment was marked as resolved.

Sign in to view
@sashaandjic

This comment was marked as resolved.

Sign in to view
sashaandjic

This comment was marked as resolved.

Sign in to view

@sashaandjic

This comment was marked as resolved.

Sign in to view
@sashaandjic
Copy link
Contributor Author

tested. all seems fine.

@marta- marta- changed the base branch from dev to CARDS-2580 September 18, 2024 19:23
@marta-
Copy link
Contributor

marta- commented Sep 18, 2024

@sashaandjic
Copy link
Contributor Author

sashaandjic commented Sep 18, 2024 •
edited
Loading

Tested, looks good. Min/Max ranges are now hidden.
In the attached pdfs, all fields were populated with a number outside min/max range. Both forms were not marked neither as Draft not Invalid.
Historical LAB.pdf
LAB.pdf

In edit mode, the proper warning message is displayed if value entered is outside of the min/max range.
image

image

@sashaandjic

This comment was marked as resolved.

Sign in to view
@marta-
Copy link
Contributor

marta- commented Sep 18, 2024

When I enabled the reinforcement for Cholesterol, the error message was displayed in 1 line.
Also, we no longer have ability to show min/max values.

Updated branch CARDS-2580 to display the default message ("Please enter values between...") instead of the custom one when min/max are enforced. Rebased this branch for testing.

@sashaandjic sashaandjic added the bug Something isn't working label Sep 18, 2024
@sashaandjic
Copy link
Contributor Author

sashaandjic commented Sep 18, 2024 •
edited
Loading

TESTED - looks good

One very minor thing ( and out of scope) that we can address later. If enforcing the min/max, display the message bellow the input line.
I really like the new message being displayed under the input line, it would improve the look if we always do it.
image
image

@sashaandjic sashaandjic removed the bug Something isn't working label Sep 18, 2024
@sashaandjic sashaandjic added tested Passed manual testing, needs code review and removed Test me! Ready for testing labels Sep 18, 2024
@Hajany
Copy link
Collaborator

Hajany commented Sep 20, 2024

Tested - minor changes:
image
image
image

@sashaandjic

This comment was marked as resolved.

Sign in to view
@marta- marta- added the on hold To be reviewed at a later time, awaiting other fixes, decisions, etc. label Sep 20, 2024
@marta-
Copy link
Contributor

marta- commented Sep 20, 2024

@sdumitriu Hold the merge until #1810 is approved and merged.

acrowthe
acrowthe approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@acrowthe acrowthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested

@sashaandjic sashaandjic added Test me! Ready for testing and removed tested Passed manual testing, needs code review labels Oct 11, 2024
Base automatically changed from CARDS-2580 to dev October 15, 2024 20:12
sashaandjic and others added 8 commits October 15, 2024 16:15
@sashaandjic @sdumitriu
HERACLES-33: Historical & Lab Results range/unit revisions
2c822ae 
Updated Laboratory Results questionnaire
@sashaandjic @sdumitriu
HERACLES-33: Historical & Lab Results range/unit revisions
dd0ea09 
Updated Historical Laboratory Results questionnaire
* added min and max values
* added value ranges in the description of the question
* added units of measurement to pro_BNP question
@sdumitriu
HERACLES-33: Historical & Lab Results range/unit revisions
ceb19d5 
Bugfix: <  and > aren't displayed
@sashaandjic @sdumitriu
HERACLES-33: Historical & Lab Results range/unit revisions
6c66df8 
Restored spaces that were removed in the previous commit from markdown-formatted descriptions
@sashaandjic @sdumitriu
HERACLES-33: Historical & Lab Results range/unit revisions
eb97fa1 
* Corrected unit of measurements for Lab Results CRP
* Added unit of measurements to Hisotrical Lab Results CRP
* Corrected pro-BNP range in Historical Lab Results
@marta- @sdumitriu
HERACLES-33: Historical & Lab Results range/unit revisions
4a0fea0 
Disabled the enforcement of min and max values for lab results
@sashaandjic @sdumitriu
HERACLES-33: Historical & Lab Results range/unit revisions
31f22cf 
Minor edits to question descriptions
@sashaandjic @sdumitriu
HERACLES-33: Historical & Lab Results range/unit revisions
e129d9b 
Changed “Total Cholesterol” field name to Cholesterol
Changed “Fasting Blood Glucose” field name to Glucose
@acrowthe acrowthe added urgent Needs to be completed and merged asap and removed on hold To be reviewed at a later time, awaiting other fixes, decisions, etc. labels Oct 23, 2024
Hajany
Hajany approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@Hajany Hajany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@acrowthe acrowthe merged commit eab531f into dev Oct 23, 2024
@acrowthe acrowthe deleted the HERACLES-33 branch October 23, 2024 15:55
@Hajany Hajany added tested Passed manual testing, needs code review and removed Test me! Ready for testing labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hajany Hajany Hajany approved these changes

@acrowthe acrowthe acrowthe approved these changes

@sdumitriu sdumitriu sdumitriu approved these changes

@marta- marta- Awaiting requested review from marta-

Assignees
No one assigned
Labels
tested Passed manual testing, needs code review urgent Needs to be completed and merged asap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sashaandjic @marta- @Hajany @sdumitriu @acrowthe