Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove useless if condition #227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove useless if condition #227

wants to merge 1 commit into from

Conversation

xiagw
Copy link

@xiagw xiagw commented May 21, 2023

No description provided.

@deitch
Copy link
Collaborator

deitch commented May 21, 2023

Is this a useless if statement? If the directory doesn't exist, this could return an exit code of 1, which could cause an error.

@xiagw
Copy link
Author

xiagw commented May 22, 2023

Is this a useless if statement? If the directory doesn't exist, this could return an exit code of 1, which could cause an error.

Because "set -e" is not enabled, it will not exit on error.

@deitch
Copy link
Collaborator

deitch commented May 22, 2023

True, although it should have been set. But this doesn't change anything either. Wy bother?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiagw @deitch