fix: fix transaction route on multi host #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaneur2020
reviewed
Sep 5, 2024
|
|
||
| public static String uriRouteHint(String URI) { | ||
| // Encode the URI using Base64 | ||
| String encodedUri = Base64.getEncoder().encodeToString(URI.getBytes()); |
There was a problem hiding this comment.
a xxhash might be possible here, might allow making this route hint shorter.
(not needed in this pr, could pick it up if one day some people complains it's too long qwq)
flaneur2020
reviewed
Sep 5, 2024
flaneur2020
reviewed
Sep 5, 2024
hantmac
reviewed
Sep 5, 2024
| return false; | ||
| } | ||
|
|
||
| private List<URI> parseURI(List<DiscoveryNode> nodes) throws SQLException { |
There was a problem hiding this comment.
Add some UT for discoverUris and parseURI function?
There was a problem hiding this comment.
I will write another PR fully test on those auto discovery related functions.
databend-jdbc/src/main/java/com/databend/jdbc/DatabendConnection.java
Outdated
Show resolved
Hide resolved
flaneur2020
reviewed
Sep 5, 2024
cdmikechen
pushed a commit
to cdmikechen/databend-jdbc
that referenced
this pull request
Oct 29, 2024
* fix: fix transaction route on multi host * chore: fix flaky cluster key * chore: ignore useless code * chore: add more comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.