chore: Split functions crate into multi crates #17133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-chore
|
Before split:
In pr:
So I think no need to split variant, string and others... |
TCeason
commented
Dec 27, 2024
…ns-scalar-arithmetic-modulo databend-functions-scalar-datetime databend-functions-scalar-decimal-utils
|
In the 069117a commit : databend-functions-scalar-arithmetic is slowest. because it has more macros. |
|
In commit b35433d
|
TCeason
commented
Dec 30, 2024
tests/sqllogictests/suites/mode/standalone/ee/explain_agg_index.test
Outdated
Show resolved
Hide resolved
sundy-li
reviewed
Dec 30, 2024
src/query/functions/tests/it/scalars/testdata/function_list.txt
Outdated
Show resolved
Hide resolved
sundy-li
reviewed
Dec 30, 2024
sundy-li
approved these changes
Dec 30, 2024
sundy-li
added
the
ci-benchmark-cloud
Docker Image for PR
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
youngsofun
pushed a commit
to youngsofun/databend
that referenced
this pull request
Jan 10, 2025
* chore: Split functions crate into multi crates * split new crate databend-functions-scalar-arithmetic databend-functions-scalar-arithmetic-modulo databend-functions-scalar-datetime databend-functions-scalar-decimal-utils * split numeric basic arithmetic and other bit arithmetic * fix ut * restore int/double arithmetic * fix
sundy-li
pushed a commit
that referenced
this pull request
Jan 10, 2025
* chore: Split functions crate into multi crates (#17133) * chore: Split functions crate into multi crates * split new crate databend-functions-scalar-arithmetic databend-functions-scalar-arithmetic-modulo databend-functions-scalar-datetime databend-functions-scalar-decimal-utils * split numeric basic arithmetic and other bit arithmetic * fix ut * restore int/double arithmetic * fix * feat(query): load ndjson support ts with diff units. (#17203) * feat(query): load ndjson/csv/tsv support ts with diff units. * fix * refactor * refactor * fix clippy --------- Co-authored-by: TCeason <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Tests
Type of change
This change is