Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regionset improvements #96

Merged
merged 23 commits into from
Mar 4, 2025
Merged

Regionset improvements #96

merged 23 commits into from
Mar 4, 2025

Conversation

khoroshevskyi
Copy link
Member

@khoroshevskyi khoroshevskyi commented Feb 19, 2025

Improved regionSet

Changes:

  • Added reading of bed file from url
  • Added calculation of digest
  • Added functions: to_bed, to_bed_gz, to_bigbed

@donaldcampbelljr donaldcampbelljr mentioned this pull request Feb 24, 2025
2 tasks
Copy link
Member

@donaldcampbelljr donaldcampbelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, needs minor cleanup.

Copy link
Member

@nleroy917 nleroy917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree just run cargo fmt, and then the only real thing I'd wanna discuss further is using Option<String> for the rest param instead of an empty string everywhere.

I think that would be better instead of allocated a bunch of empty strings everywhere, right?

So its:

struct Rust {
  pub chr: String,
  pub start: u32,
  pub end: u32,
  pub rest: Option<String>
}

Copy link
Member

@donaldcampbelljr donaldcampbelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@nleroy917 nleroy917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to get to it all. The only critical thing is the double import of:

// bindings/python/src/digests/mod.rs
use gtars::digests::{md5, sha512t24u, DigestResult};

Nothing will build or run otherwise. Do you use rust-analyzer and clippy? Both are really good at catching things like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants