Skip to content

Conversation

tvolge
Copy link
Contributor

@tvolge tvolge commented Sep 2, 2024

No description provided.

@tvolge tvolge added the patch Patch (Semantic Versioning) label Sep 2, 2024
@tvolge tvolge requested review from bwiz and slavkor September 2, 2024 11:13
@tvolge tvolge self-assigned this Sep 2, 2024
@tvolge tvolge requested a review from alekseimi September 3, 2024 07:43
Copy link
Collaborator

@alekseimi alekseimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from minor issues that detract from the readability of the code, looks good.

Additionally: The file (module) name pushData.py is in camel case. The PEP-8 standard expects snake case, e.g push_data.py

Since this is an example, I took the liberty to add additional clarifying comments.

@bwiz bwiz requested a review from alekseimi September 19, 2024 13:16
@alekseimi alekseimi merged commit 1749336 into master Sep 19, 2024
1 check passed
@alekseimi alekseimi deleted the python-example branch September 19, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Patch (Semantic Versioning)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants