Revert using IsPromptSupported from promptOrAssignDefaultValues #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
@andrewnester This means that the Git Bash change in #1069 now does not apply when prompting for bundle template variables, which IIRC was what raised this in the first place.
|
@pietern the original issue was reported for choosing template and the check is there https://github.com/databricks/cli/blob/main/cmd/bundle/init.go#L134 But indeed, makes sense to bring |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
## Changes Follow up on #1077
shreyas-goenka
added a commit
that referenced
this pull request
Dec 20, 2023
CLI: * Upgrade Go SDK to 0.27.0 ([#1064](#1064)). * Skip profile resolution if `DATABRICKS_AUTH_TYPE` is set ([#1068](#1068)). * Test existing behavior when loading non-string spark conf values ([#1071](#1071)). * Do not allow input prompts in Git Bash terminal ([#1069](#1069)). * Added output template for list-secrets command ([#1074](#1074)). * Set metadata fields required to enable break-glass UI for jobs ([#880](#880)). * Revert using IsPromptSupported from promptOrAssignDefaultValues ([#1077](#1077)). * Do not prompt for template values in Git Bash ([#1082](#1082)). Bundles: * **FILL THIS IN MANUALLY BY MOVING RELEVANT ITEMS FROM ABOVE LIST** Internal: * **FILL THIS IN MANUALLY BY MOVING RELEVANT ITEMS FROM ABOVE LIST** API Changes: * Changed `databricks connections update` command with new required argument order. * Changed `databricks serving-endpoints update-config` command with new required argument order. * Added `databricks serving-endpoints put` command. * Removed `databricks account network-policy` command group. OpenAPI commit 63caa3cb0c05045e81d3dcf2451fa990d8670f36 (2023-12-12) Dependency updates: * Bump github.com/google/uuid from 1.4.0 to 1.5.0 ([#1073](#1073)). * Bump golang.org/x/crypto from 0.16.0 to 0.17.0 ([#1076](#1076)).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes nightly test
TestAccBundleInitErrorOnUnknownFields.TestAccBundleInitErrorOnUnknownFieldshas an interactive shell by default so the test fails on waiting for prompt.This was introduced in #1069.
Tests
Nightly test succeed.