Restore variable file tests #2220
Conversation
ilyakuz-db
requested review from
pietern,
andrewnester,
shreyas-goenka and
denik
as code owners
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
Windows failed due to slashes, can you try adding |
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
| # title "file cannot be parsed" | ||
| # trace errcode $CLI bundle validate -o json --target invalid_json | jq $cluster_expr | ||
| title "file cannot be parsed" | ||
| trace errcode $CLI bundle validate -o json --target invalid_json | jq $cluster_expr | sed 's/\\/\//g' |
There was a problem hiding this comment.
This can be fixed with:
trace errcode $CLI bundle validate -o json --target invalid_json 2>&1 | sed 's/\\/\//g'
The jq expression is not needed because the command fails. The error is written to stderr so we need a redirect.
There was a problem hiding this comment.
The jq expression is not needed because the command fails
Otherwise it will print all json output in addition to the error, example
There was a problem hiding this comment.
Can you use Repls instead of sed? See example: https://github.com/databricks/cli/blob/main/acceptance/selftest/test.toml#L17
There was a problem hiding this comment.
Can you use Repls instead of sed? See example: https://github.com/databricks/cli/blob/main/acceptance/selftest/test.toml#L17
Looks good, let me try
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
| # Fix for windows | ||
| [[Repls]] | ||
| Old = '\$TMPDIR\\.databricks\\bundle\\wrong_file_structure\\variable-overrides.json' | ||
| New = '$TMPDIR/.databricks/bundle/wrong_file_structure/variable-overrides.json' |
There was a problem hiding this comment.
The $ is interpreted as a reference to match. You can indicate a $ literal with $$:
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Changes
Uncomment flaky tests, they work properly with latest changes from main
Tests