Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acc: Restore unexpected output error #2243

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

denik
Copy link
Contributor

@denik denik commented Jan 27, 2025

Changes

Restore original behaviour of acceptance tests: any unaccounted for files trigger an error (not just those that start with "out"). This got changed in https://github.com/databricks/cli/pull/2146/files#diff-2bb968d823f4afb825e1dcea2879bdbdedf2b7c15d4e77f47905691b14246a04L196 which started only checking files starting with "out*" and skipping everything else.

Tests

Existing tests.

@@ -0,0 +1,3 @@
[[Repls]]
Old = '\\\\myrepo'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does old/new means here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes directly from testdiff.Replacement - Old is regex, New is replacement (in regex format).

type Replacement struct {
	Old *regexp.Regexp
	New string
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, got it, name Repls confused me a bit, thought it relates to REPLs (terminals)

@denik denik added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 60709e3 Jan 28, 2025
9 checks passed
@denik denik deleted the denik/restore-unexpected-output branch January 28, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants