Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acc: Include "id" into /api/2.0/preview/scim/v2/Me response #2266

Merged
merged 2 commits into from
Jan 29, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
acc: Include "Id" into /api/2.0/preview/scim/v2/Me response
This is something terraform provider expects.
denik committed Jan 29, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 274f56dd05468e8c3337a25d2319ecf6bb459743
2 changes: 2 additions & 0 deletions acceptance/bundle/variables/git-branch/output.txt
Original file line number Diff line number Diff line change
@@ -29,6 +29,7 @@
"workspace": {
"artifact_path": "/Workspace/Users/$USERNAME/.bundle/git/prod/artifacts",
"current_user": {
"id": "$USERNAME",
"short_name": "$USERNAME",
"userName": "$USERNAME"
},
@@ -78,6 +79,7 @@ Validation OK!
"workspace": {
"artifact_path": "/Workspace/Users/$USERNAME/.bundle/git/dev/artifacts",
"current_user": {
"id": "$USERNAME",
"short_name": "$USERNAME",
"userName": "$USERNAME"
},
Original file line number Diff line number Diff line change
@@ -54,6 +54,7 @@
"workspace": {
"artifact_path": "/Users/$USERNAME/path/to/root/artifacts",
"current_user": {
"id": "$USERNAME",
"short_name": "$USERNAME",
"userName": "$USERNAME"
},
1 change: 1 addition & 0 deletions acceptance/bundle/variables/resolve-builtin/output.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"artifact_path": "TestResolveVariableReferences/bar/artifacts",
"current_user": {
"id": "$USERNAME",
"short_name": "$USERNAME",
"userName": "$USERNAME"
},
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"artifact_path": "TestResolveVariableReferencesToBundleVariables/bar/artifacts",
"current_user": {
"id": "$USERNAME",
"short_name": "$USERNAME",
"userName": "$USERNAME"
},
1 change: 1 addition & 0 deletions acceptance/server_test.go
Original file line number Diff line number Diff line change
@@ -54,6 +54,7 @@ func AddHandlers(server *testserver.Server) {

server.Handle("GET /api/2.0/preview/scim/v2/Me", func(r *http.Request) (any, error) {
return iam.User{
Id: "[email protected]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it's a string, for correctness it should still represent the number (int64)
https://docs.databricks.com/api/workspace/currentuser/me#id

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, fixed here 4b6211c

UserName: "[email protected]",
}, nil
})