-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CreatePipeline instead of PipelineSpec for resources.Pipeline struct #2287
base: main
Are you sure you want to change the base?
Conversation
Is it possible to use new API stubbing functionality (example: https://github.com/databricks/cli/blob/main/acceptance/workspace/jobs/create/test.toml#L6) to add a couple of acceptance tests:
|
"dry_run": | ||
"description": |- | ||
PLACEHOLDER | ||
"run_as": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both run_as
and dry_run
don't seem to be supported in terraform? For run_as
we should add support, but for dry_run
we can either add support or remove it from the bundle schema
.
Note, we can also switch over to using CreatePipeline
in TF as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run_as will be supported in the next TF release, the rest indeed is not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it would be nice to drop dry_run
and allow_duplicate_names
from the schema, but we have examples of other resources with properties we don't intend to support so we can deal with that separately.
Just so that we can omit these properties later, could you make sure that they're not forwarded to TF as part of tfdyn? That way we can remove them later (when we also take a closer look at properties included for other resources) and not regress anything.
340103d
to
8245da8
Compare
Changes
CreatePipeline
is a more complete structure (superset of PipelineSpec one) which enables support of additional fields such asrun_as
andallow_duplicate_names
in DABs configuration. Note: these fields are subject to support in TF in order to correctly work.Tests
Existing tests pass + no fields are removed from JSON schema