Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for extras to the labs CLI #2288

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Add support for extras to the labs CLI #2288

merged 3 commits into from
Feb 5, 2025

Conversation

mwojtyczka
Copy link
Contributor

@mwojtyczka mwojtyczka commented Feb 4, 2025 •
edited by pietern
Loading

Changes

Added support for extras / optional Python dependencies in the labs CLI.

Added new extras field under install.

Example:

install:
  script: install.py
  extras: cli

Resolves: #2257

Tests

Manual test

alexott
alexott approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

An authorized user can trigger integration tests manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 2288
  • Commit SHA: 9a51e31975fd09bca04f00a010ad2485b2804b7c

Checks will be approved automatically on success.

@mwojtyczka mwojtyczka mentioned this pull request Feb 4, 2025
Open
3 tasks
@pietern pietern changed the title Added support for extras in Labs CLI Add support for extras to the labs CLI Feb 4, 2025
@pietern pietern added this pull request to the merge queue Feb 5, 2025
Merged via the queue into databricks:main with commit 27caf41 Feb 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietern pietern pietern approved these changes

@alexott alexott alexott approved these changes

@andrewnester andrewnester Awaiting requested review from andrewnester

@shreyas-goenka shreyas-goenka Awaiting requested review from shreyas-goenka

@denik denik Awaiting requested review from denik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support extras in Databricks Labs CLI installer to support optional python dependencies
3 participants
@mwojtyczka @pietern @alexott