Remove TODO for short flags in Templates #3103
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthban-db
requested review from
pietern,
andrewnester,
shreyas-goenka,
denik and
anton-107
as code owners
parthban-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
Can you add Why section in PR description? |
|
@parthban-db Could you regenerate the code, or at least confirm that the template changes do not cause any problems in the generated code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove TODO for short flags in Templates.
Why
Cleaning up the templates. If we need short flags, we don't need a todo in the template.
Tests
Exisiting CI